[Vobject] Bug in icalendar.py

Jeffrey Harris jeffrey at osafoundation.org
Fri Jul 7 19:18:52 CDT 2006

Hi Cyrus,

> The following fix seem to do the trick:
>  if until is not None and isinstance(dtstart, datetime.datetime) and
> (until.tzinfo != dtstart.tzinfo):
> However, I'm not totally sure what all this 'until' testing is about at
> that point in the code so I would prefer someone else to examine this
> and make sure the fix is appropriate before going ahead and committing it.

The fix is good, thanks.

That code block was added to fix
https://bugzilla.osafoundation.org/show_bug.cgi?id=5773, handle an
icalendar stream with a datetime DTSTART but a date UNTIL (Mozilla
produces RRULEs like this).

It looks like I fixed that case but broke the more common case where
both UNTIL and DTSTART are dates.

On rereading, the comment I added about this code was fairly opaque,
feel free to add a clearer comment when you commit your fix!


More information about the VObject mailing list